Question about r51765

Coordinator
Jun 10, 2010 at 11:03 PM

Hi Lars,

I was looking at r51765 last night and was wondering if the condition in this was back to front:

// skip non-dotnet-references
if (ArtifactTypeHelper.isDotnet( dependency.getType() ))
    continue;

It says it wants to skip non-dotnet, but seems to skip dotnet. This change was rolled back for 1.2 due to problems - could this be the reason?

Developer
Jun 11, 2010 at 10:13 AM

Yes, that code seems simply wrong :-(

The original commit message also was: 

[#13296] Skip copy of non-dotnet-dependencies to PAB
git-svn-id: https://npanday.svn.codeplex.com/svn/trunk@51765

http://github.com/lcorneliussen/npanday/commit/181e69a04f774fa57dc68d3b3203cdda6211fe43

Funny, though that it still fixed this issue (at least locally for me): http://npanday.codeplex.com/workitem/13296

Coordinator
Jun 11, 2010 at 10:43 AM

we probably need to work on the tests both for what this fixed, and what the fix broke then. But maybe best left until trunk can undergo surgery? :)

Should that issue be reopened now that it was rolled back?

Developer
Jun 11, 2010 at 2:21 PM

On my machine i had to fix it because some its failed. I'll try RC4 next week and see. If i have the same errors again I'll reopen, write some tests and fix the fix.

Coordinator
Jun 13, 2010 at 12:14 AM

Cool... if a fix is not needed, we should probably just remove the fix version from the issue (since the change wasn't applied).

Developer
Jun 14, 2010 at 8:19 AM
I reopened it and moved it to the backlog. I'll reevaluate the problem.