How do you review code changes?

Developer
Jan 22, 2009 at 4:46 PM
Edited Jan 22, 2009 at 4:47 PM
Just wondering if anyone has a system for reviewing changes to the NPanday source code or if I'm entirely missing something...

The 'Source Code' tab lists the commit messages, provides a download link for a multi-megabyte 'changeset' zip file, and allows you to browse what I assume is the state of the repository after that commit.  The RSS feed only shows the commit message, it doesn't include a diff so you can see what was changed.

I realize this isn't Subversion behind the scenes but TFS with a bridge for svn clients.  How are people dealing with this?

I've been running the following commands on my working copy for each commit:

$ svn log -r24125
$ svn diff -r24124:24125

(If that doesn't produce anything, then the commit probably wasn't on /trunk, so I add the remote url [1] to the end of the command.  This takes *forever*.)

I've put a few of these logs-and-diffs up here:  http://wsmoak.net/npanday/2009/01/

If these are useful to anyone else, maybe I'll make it an RSS feed... let me know.

[1] https://npanday.svn.codeplex.com/svn

--
Wendy
Editor
Jan 22, 2009 at 6:28 PM
Hello,

on my side I reply or on my IDE (IntelliJ) or on tortoise SVN so I can get all the needed informations (revision + changes + comment).
But I have to admit that I cannot use IntelliJ to make updates because it always fails with a timeout or something (codeplex svn is not that good). But using tortoise on windows or the command line tool on unix work well.

Regards,
Cédric,

On Thu, Jan 22, 2009 at 6:46 PM, wsmoak <notifications@codeplex.com> wrote:

From: wsmoak

Just wondering if anyone has a system for reviewing changes to the NPanday source code or if I'm entirely missing something...

The 'Source Code' tab lists the commit messages, provides a download link for a multi-megabyte 'changeset' zip file, and allows you to browse what I assume is the state of the repository after that commit. The RSS feed only shows the commit message, it doesn't include a diff so you can see what was changed.

I realize this isn't Subversion behind the scenes but TFS with a bridge for svn clients. How are people dealing with this?

I've been running the following commands on my working copy for each commit:

$ svn log -r24125
$ svn diff -r24124:24125

(If that doesn't produce anything, then the commit probably wasn't on /trunk, so I add the remote url [1] to the end of the command. This takes *forever*.)

I've put a few of these logs-and-diffs up here: http://wsmoak.net/npanday/2009/01/

If these are useful to anyone else, maybe I'll make it an RSS feed... let me know.

[1] https://npanday.svn.codeplex.com/svn

--
Wendy

Read the full discussion online.

To add a post to this discussion, reply to this email (npanday@discussions.codeplex.com)

To start a new discussion for this project, email npanday@discussions.codeplex.com

You are receiving this email because you subscribed to this discussion on CodePlex. You can unsubscribe or change your settings on codePlex.com.

Please note: Images and attachments will be removed from emails. Any posts to this discussion will also be available online at codeplex.com


Developer
Feb 24, 2009 at 1:05 AM
Cédric wrote:
> on my side I reply or on my IDE (IntelliJ) or on tortoise SVN so I can get all the needed informations (revision + changes + comment).

This only shows you the changes that happened on the trunk or branch you're working on, right?  I'm interested in changes happening across the project, for example when a tag or a branch is created, or if someone makes a change to a tag, which generally shouldn't happen.

I'm just used to every change in the source code being sent to a mailing list where people can review it.  Typically it's a separate list, so people can opt in, and then if anyone has a question or comment, the reply goes to the development discussion list.  The way Codeplex is set up, it takes a lot of effort to review the changes and to ask a question about a particular change.

Is this a concern for anyone else?  Any ideas?

For the moment I'm still publishing the svn diffs on my website.  February is here:  http://wsmoak.net/npanday/2009/02/

--
Wendy
Editor
Mar 5, 2009 at 8:45 AM
As TFS is behind the scene at CodePlex isn't anything we can do to use TFS notification features? If anyone has knowledge on it and/or can ask to CodePlex support?

Cedric,

On Tue, Feb 24, 2009 at 3:05 AM, wsmoak <notifications@codeplex.com> wrote:

From: wsmoak

Cédric wrote:
> on my side I reply or on my IDE (IntelliJ) or on tortoise SVN so I can get all the needed informations (revision + changes + comment).

This only shows you the changes that happened on the trunk or branch you're working on, right?  I'm interested in changes happening across the project, for example when a tag or a branch is created, or if someone makes a change to a tag, which generally shouldn't happen.

I'm just used to every change in the source code being sent to a mailing list where people can review it.  Typically it's a separate list, so people can opt in, and then if anyone has a question or comment, the reply goes to the development discussion list.  The way Codeplex is set up, it takes a lot of effort to review the changes and to ask a question about a particular change.

Is this a concern for anyone else?  Any ideas?

For the moment I'm still publishing the svn diffs on my website.  February is here:  http://wsmoak.net/npanday/2009/02/

--
Wendy

Read the full discussion online.

To add a post to this discussion, reply to this email (npanday@discussions.codeplex.com)

To start a new discussion for this project, email npanday@discussions.codeplex.com

You are receiving this email because you subscribed to this discussion on CodePlex. You can unsubscribe or change your settings on codePlex.com.

Please note: Images and attachments will be removed from emails. Any posts to this discussion will also be available online at codeplex.com


Coordinator
Mar 16, 2009 at 2:46 AM
If the TFS option isn't possible, what about requesting open source hosting here: http://fisheye2.atlassian.com/?