1
Vote

Additional parameters for wix-maven-plugin

description

Currently this is no parameter for processor architecture (-arch) in CandleMojo.
 
Also there are other parameters which are not defined in wix mojos and it would be inefficient to add all those parameters into wix-maven-plugin one by one. A single parameter should used to pass additional arguments into light/candle as is.

file attachments

comments

jocaba wrote Aug 30, 2010 at 1:29 AM

currently checking on the patch.

Thanks,

wsmoak wrote Sep 1, 2010 at 11:38 AM

I don't agree that using a generic parameter is the way to go. The Maven plugin should have a parameter for each one so that it can be documented.

Here's an example, the Javadoc plugin for Java has lots of parameters, and it works fine.

Can you clarify what this patch actually does, since it seems to have a line ending problem and shows every line being removed and replaced?

jocaba wrote Sep 2, 2010 at 6:29 AM

+1 on following the convention for maven plugins.

I know that the wix plugin doesn't have every configuration added yet, but we could add those later on when the need arises.

Maybe we could change this issue to describe which configuration the user is using for the wix plugin?

brettporter wrote Sep 3, 2010 at 5:06 PM

applying the patch, I see that the line endings resolve themselves.

This simply adds a catch-all arguments, and doesn't replace the existing. It adds 'arch' as a specific one in the way you suggest. I think that's reasonable to apply - you get the flexibility of being able to configure anything you want, while we can code in the ones that we know about in advance for better type safety / documentation / etc.

re-attaching with the smaller set of changes, and based from the toplevel npanday directory.

dmitryl wrote Sep 9, 2010 at 2:17 PM

The same approach is used in maven-compile-plugin (http://www.npanday.org/docs/1.2/plugins/maven-compile-plugin/compile-mojo.html#parameters).

Sign in to add a comment or to set email notifications